(chore) Use standalone proptypes #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
interesting how this broke storybook! |
|
Wonder if this is related? storybookjs/storybook#1723 |
|
off the cuff instinct is no, gonna investigate further. |
|
this PR got merged that fixes the issue, gonna try running storybook from master lol |
MaxBittker
force-pushed
the
standalone-proptypes
branch
from
0e71718 to
c7f82be
Compare
|
upgrading storybook to ^3.2.0 fixed this - want me to pin a specific patch? this is ready to review (and merge?) now i believe @billyvg. thoughts on the percy results? |
MaxBittker
changed the title
billyvg
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for react 16