Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(relocation): 23.11.2 release tests #60900

Merged
merged 2 commits into from
Dec 5, 2023
Merged

chore(relocation): 23.11.2 release tests #60900

merged 2 commits into from
Dec 5, 2023

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 requested a review from a team November 30, 2023 19:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 30, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Merging #60900 (69ee8a1) into master (46377d4) will decrease coverage by 0.01%.
Report is 85 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #60900      +/-   ##
==========================================
- Coverage   80.95%   80.95%   -0.01%     
==========================================
  Files        5181     5183       +2     
  Lines      226953   227211     +258     
  Branches    38136    38187      +51     
==========================================
+ Hits       183731   183932     +201     
- Misses      37608    37663      +55     
- Partials     5614     5616       +2

see 64 files with indirect coverage changes

azaslavsky
azaslavsky suggested changes Dec 1, 2023
View reviewed changes
tests/sentry/backup/test_releases.py Outdated Show resolved Hide resolved
@hubertdeng123 hubertdeng123 merged commit 3077911 into master Dec 5, 2023
46 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/23.11.2-release-tests branch December 5, 2023 23:04
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 5, 2023 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: import_in_global_scope() missing 1 required keyword-only argument: 'printer' pytest.runtest.protocol tests/sentry/backup/tes... View Issue
  • ‼️ TypeError: import_in_global_scope() missing 1 required keyword-only argument: 'printer' pytest.runtest.protocol tests/sentry/backup/tes... View Issue

Did you find this useful? React with a 👍 or 👎

@asottile-sentry
Copy link
Member

reverting: this is breaking CI

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Dec 5, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: d868c77

getsentry-bot added a commit that referenced this pull request Dec 5, 2023
@getsentry-bot @asottile-sentry
Revert "chore(relocation): 23.11.2 release tests (#60900)"
d868c77 
This reverts commit 3077911.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
@hubertdeng123 hubertdeng123 mentioned this pull request Dec 5, 2023
Merged
hubertdeng123 added a commit that referenced this pull request Dec 6, 2023
@hubertdeng123
chore(relocation): 23.11.2 Release Tests, now fixed (#61204)
1a68216 
follow up to #60900
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azaslavsky azaslavsky azaslavsky approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 23.11.2
4 participants
@hubertdeng123 @asottile-sentry @getsentry-bot @azaslavsky