ref(crons): message_type is always available #60926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Nov 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60926 +/- ##
==========================================
- Coverage 80.96% 80.95% -0.01%
==========================================
Files 5182 5182
Lines 227008 227006 -2
Branches 38148 38147 -1
==========================================
- Hits 183786 183779 -7
- Misses 37608 37613 +5
Partials 5614 5614
|
After getsentry/relay#2723 this field is guaranteed to exist in the CheckinMessage. We no longer need to add this in and have it marked as NotRequired.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-message-type-is-always-available
branch
from
a57f661 to
34ba03b
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-message-type-is-always-available
branch
ArthurKnaus
pushed a commit
that referenced
this pull request
Dec 1, 2023
After getsentry/relay#2723 this field is guaranteed to exist in the CheckinMessage. We no longer need to add this in and have it marked as NotRequired.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getsentry/relay#2723 this field is
guaranteed to exist in the CheckinMessage. We no longer need to add this
in and have it marked as NotRequired.