Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay): Introduce options to global config #61024

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Dec 4, 2023

Setup infrastructure to add options to the global config, also update the global config endpoint to signal relay the global config is fully ready.

Relay PR: getsentry/relay#2813

@Dav1dde Dav1dde requested a review from a team December 4, 2023 09:02
@Dav1dde Dav1dde self-assigned this Dec 4, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #61024 (41a6c01) into master (bb82f15) will decrease coverage by 1.95%.
Report is 60 commits behind head on master.
The diff coverage is 68.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #61024      +/-   ##
==========================================
- Coverage   82.97%   81.02%   -1.95%     
==========================================
  Files        5536     5184     -352     
  Lines      236356   227443    -8913     
  Branches    38182    38200      +18     
==========================================
- Hits       196108   184287   -11821     
+ Misses      39958    37520    -2438     
- Partials      290     5636    +5346     
Files Coverage Δ
src/sentry/api/endpoints/relay/project_configs.py 95.81% <100.00%> (-1.56%) ⬇️
src/sentry/relay/globalconfig.py 72.22% <66.66%> (-27.78%) ⬇️

... and 1844 files with indirect coverage changes

Comment on lines +30 to +31
if options:
global_config["options"] = options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test it with relay library and make sure this is the protocol relay expects, like in

You may need to make a new librelay release too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be tested the moment we actually add an option we want exposed in Relay. Now this requires monkey patching the global list and the next person adding the first option would actually have to remember to remove the monkey patch again.

Dav1dde and others added 2 commits December 5, 2023 08:41
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
@Dav1dde Dav1dde merged commit b577848 into master Dec 5, 2023
@Dav1dde Dav1dde deleted the feat/relay-global-config-options branch December 5, 2023 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants