-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relay): Introduce options to global config #61024
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #61024 +/- ##
==========================================
- Coverage 82.97% 81.02% -1.95%
==========================================
Files 5536 5184 -352
Lines 236356 227443 -8913
Branches 38182 38200 +18
==========================================
- Hits 196108 184287 -11821
+ Misses 39958 37520 -2438
- Partials 290 5636 +5346
|
db12e3a
to
83d7c6f
Compare
if options: | ||
global_config["options"] = options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test it with relay library and make sure this is the protocol relay expects, like in
def test_global_config(): |
You may need to make a new librelay release too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be tested the moment we actually add an option we want exposed in Relay. Now this requires monkey patching the global list and the next person adding the first option would actually have to remember to remove the monkey patch again.
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Setup infrastructure to add options to the global config, also update the global config endpoint to signal relay the global config is fully ready.
Relay PR: getsentry/relay#2813