Skip to content

Conversation

@macqueen
Copy link
Contributor

part 2/3, depends on #6136

cc @getsentry/workflow

@ghost
Copy link

ghost commented Sep 18, 2017

2 Warnings
⚠️ You should update CHANGES due to the size of this PR
⚠️ PR includes migrations

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

Copy link
Member

@dcramer dcramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to deploy part 1 before deploying part 2

@mattrobenolt
Copy link
Contributor

We doing this? This is in my review queue even though it's been approved. :)

@macqueen
Copy link
Contributor Author

@mattrobenolt i was gonna wait until part 3 (where we actually use the new fields) is closer to being done. i can kick you off as a reviewer

@macqueen macqueen merged commit 5fc97b3 into master Jan 8, 2018
@macqueen macqueen deleted the project-team-2 branch January 8, 2018 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants