Clean up logic around exception type/value #6296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
i see you are immediately jumping into 'sentry accepts any kind of garbage data you throw at it' hell |
Contributor
Author
|
Ha, nah this was just an opportunistic fix from playing around with the product. But I guess maybe I've started down the road to hell here :) |
Contributor
|
Might as well add a test. 💅 |
Only if value is a string, can we split() it. Otherwise if it is not None we can json.dumps() it. Added test. Should fix SENTRY-3XB https://sentry.io/sentry/sentry/issues/317019975/
alex-hofsteede
force-pushed
the
alex/SENTRY-3XB
branch
from
1d54cba to
f2a22b3
Compare
Contributor
Author
|
test added, fails on master, passes on this branch |
This was referenced Mar 17, 2020
This was referenced Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only if value is a string, can we
split()it. Otherwise if it is notNonewe canjson.dumps()it.Should fix SENTRY-3XB https://sentry.io/sentry/sentry/issues/317019975/