Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-crashes): Add org allowlist for RN #63226

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 16, 2024

Add an optional organization allowlist for React-Native to specify which organizations
the SDK crash detection is enabled per SDK configuration.

Add an optional organization allowlist to specify which organizations
the SDK crash detection is enabled per SDK configuration.
@philipphofmann philipphofmann requested a review from a team as a code owner January 16, 2024 08:44
@philipphofmann philipphofmann requested a review from a team January 16, 2024 08:44
@philipphofmann philipphofmann self-assigned this Jan 16, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3422b02) 81.35% compared to head (70012e6) 81.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #63226   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files        5205     5205           
  Lines      230790   230800   +10     
  Branches    39875    39877    +2     
=======================================
+ Hits       187755   187770   +15     
+ Misses      37277    37274    -3     
+ Partials     5758     5756    -2     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
...s/sdk_crashes/build_sdk_crash_detection_configs.py 100.00% <100.00%> (ø)
...rc/sentry/utils/sdk_crashes/sdk_crash_detection.py 88.33% <100.00%> (+0.61%) ⬆️
...ry/utils/sdk_crashes/sdk_crash_detection_config.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@philipphofmann philipphofmann merged commit b24367b into master Jan 16, 2024
53 checks passed
@philipphofmann philipphofmann deleted the feat/sdk-config-org-allowlist branch January 16, 2024 09:23
trillville pushed a commit that referenced this pull request Jan 19, 2024
Add an optional organization allowlist for React-Native to specify which
organizations
the SDK crash detection is enabled per SDK configuration.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants