ref(csp): Validate CSP reports with JSON schema #6340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
alex-hofsteede
commented
Oct 16, 2017
| # NB this schema validates the version of the CSP report we create after | ||
| # validate_data() which changes hyphens to underscores in the key names. | ||
|
|
||
| CSP_POLICY_VIOLATION_REPORT_SCHEMA = { |
Contributor
Author
There was a problem hiding this comment.
From the department of redundancy department.
mattrobenolt
approved these changes
Oct 16, 2017
Contributor
mattrobenolt
left a comment
mattrobenolt
left a comment
There was a problem hiding this comment.
I don't really know json schema, but since it passes current tests, lgtm. 🍪
mitsuhiko
approved these changes
Oct 16, 2017
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
This diff is surprisingly hard to read. It's good but note that filter returns a generator on 3.x. It works atm but maybe name it uris_iter so that is clear.
Member
|
I'd generally say avoid using |
In preparation for accepting other types of browser security reports, start using JSON schema to validate the structure of these documents to avoid duplicating a bunch of manual validation for the different report types.
alex-hofsteede
force-pushed
the
alex/json-csp
branch
from
9ca3c8d to
7c6351a
Compare
Contributor
Author
|
Superseded by #6417 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for accepting other types of browser security reports,
start using JSON schema to validate the structure of these documents
to avoid duplicating a bunch of manual validation for the different
report types.