ref(sdk-crashes): Make allowlist nonoptional #63817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allowlist option for RN can't be None, as it is defined as a sequence. Therefore, we change it to nonoptional. When the list is empty, all organizations are allowed. You can use the sample rate instead to turn off the detection for an SDK.
philipphofmann
added
the
Scope: Backend
iker-barriocanal
approved these changes
Jan 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #63817 +/- ##
=======================================
Coverage 81.39% 81.40%
=======================================
Files 5224 5224
Lines 232185 232185
Branches 40190 40190
=======================================
+ Hits 188996 189001 +5
+ Misses 37349 37347 -2
+ Partials 5840 5837 -3
|
snigdhas
pushed a commit
that referenced
this pull request
Jan 26, 2024
The allowlist option for RN can't be None, as it is defined as a sequence, [see GH actions](https://github.com/getsentry/sentry-options-automator/actions/runs/7651413445/job/20849155404?pr=626). Therefore, we change it to nonoptional. When the list is empty, all organizations are allowed. You can use the sample rate instead to turn off the detection for an SDK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowlist option for RN can't be None, as it is defined as a sequence, see GH actions. Therefore, we change it to nonoptional. When the list is empty, all organizations are allowed. You can use the sample rate instead to turn off the detection for an SDK.