Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): Add Sentry Babel plugin for React component annotation #64439

Merged
merged 14 commits into from
Feb 6, 2024
Merged

feat(plugins): Add Sentry Babel plugin for React component annotation #64439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6f24b60
feat(plugins): Add Sentry Babel plugin for react component annotation
0Calories Feb 2, 2024
96c2c9c
remove fullstory plugin
0Calories Feb 2, 2024
d4d76f7
oops wrap it in an array
0Calories Feb 2, 2024
21ae953
try using just the string identifier for the plugin
0Calories Feb 2, 2024
593f098
rename component dataset attribute to sentryComponent
0Calories Feb 2, 2024
192a36b
rename the plugin
0Calories Feb 5, 2024
7d2f768
put plugin-transform-class-properties back in
0Calories Feb 5, 2024
1df9d54
make babel plugin a dependency
0Calories Feb 5, 2024
9d495c7
Merge branch 'master' into feat/use-sentry-component-annotate-plugin
0Calories Feb 5, 2024
b9ee47e
Upgrade plugin to latest version
0Calories Feb 5, 2024
3c6d5fc
fix config
0Calories Feb 5, 2024
d62a999
Merge branch 'master' into feat/use-sentry-component-annotate-plugin
0Calories Feb 5, 2024
7de1fd1
resolve merge conflict
0Calories Feb 5, 2024
782f35b
Merge branch 'master' into feat/use-sentry-component-annotate-plugin
0Calories Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions babel.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ const config: TransformOptions = {
},
],
['babel-plugin-add-react-displayname'],
'@sentry/babel-plugin-component-annotate',
],
},
development: {
plugins: [
'@emotion/babel-plugin',
'@babel/plugin-transform-react-jsx-source',
'@sentry/babel-plugin-component-annotate',
...(process.env.SENTRY_UI_HOT_RELOAD ? ['react-refresh/babel'] : []),
],
},
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"@sentry-internal/rrweb": "2.9.0",
"@sentry-internal/rrweb-player": "2.9.0",
"@sentry-internal/rrweb-snapshot": "2.9.0",
"@sentry/babel-plugin-component-annotate": "^2.14.0",
"@sentry/core": "^7.99.0",
"@sentry/integrations": "^7.99.0",
"@sentry/node": "^7.99.0",
Expand Down
4 changes: 3 additions & 1 deletion static/app/utils/performanceForSentry/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ function getNearestElementName(node: HTMLElement | undefined | null): string | u
let current: HTMLElement | null = node;
while (current && current !== document.body) {
const elementName =
current.dataset?.testId ?? current.dataset?.component ?? current.dataset?.element;
current.dataset?.testId ??
current.dataset?.sentryComponent ??
current.dataset?.element;

if (elementName) {
return elementName;
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2858,6 +2858,11 @@
"@sentry/types" "7.99.0"
"@sentry/utils" "7.99.0"

"@sentry/babel-plugin-component-annotate@^2.14.0":
version "2.14.0"
resolved "https://registry.yarnpkg.com/@sentry/babel-plugin-component-annotate/-/babel-plugin-component-annotate-2.14.0.tgz#e62f448dd3c922a6d32e9f1c0a5ae85fa6ec22c2"
integrity sha512-FWU4+Lx6fgxjAkwmc3S9j1Q/6pqKZyZzfi52B+8WMNw7a5QjGXgxc5ucBazZYgrcsJKCFBp4QG3PPxNAieFimQ==

"@sentry/browser@7.99.0":
version "7.99.0"
resolved "https://registry.yarnpkg.com/@sentry/browser/-/browser-7.99.0.tgz#3e78beb490d141c988038ea902689a1e9171c6cf"
Expand Down
Loading