feat(ddm): Implement global abuse limits for metrics #64574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #64574 +/- ##
==========================================
- Coverage 81.36% 81.30% -0.07%
==========================================
Files 5236 5245 +9
Lines 231130 232306 +1176
Branches 45348 45535 +187
==========================================
+ Hits 188058 188869 +811
- Misses 37220 37577 +357
- Partials 5852 5860 +8
|
Dav1dde
approved these changes
Feb 7, 2024
olksdr
approved these changes
Feb 7, 2024
| assert quotas[5].scope == QuotaScope.GLOBAL | ||
| assert quotas[5].scope_id is None | ||
| assert quotas[5].categories == {DataCategory.METRIC_BUCKET} | ||
| assert quotas[5].limit == 6040 |
There was a problem hiding this comment.
where is this number coming from?
There was a problem hiding this comment.
Above here I set the limit to 604.
self.organization.update_option("global-abuse-quota.metric-bucket-limit", 604)
since the abuse_window is 10 seconds its multiplied by 10
iker-barriocanal
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements global abuse limit for metric buckets.
Relay: getsentry/relay#2928
Epic: getsentry/relay#2716