ref: Change EventTag writes to write in bulk #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
eventtag-bulk-create
branch
from
afe856a to
e67eef4
Compare
Generated by 🚫 danger |
Contributor
|
Nice |
It's easily possible that this is 10+ at bare minimum, sometimes into hundreds of tags per Event. So changing this to a bulk write means we have 1 transaction and one big INSERT query which should be considerable speed improvement. We can get away with this since we currently have a UNIQUE on (event_id, key_id, value_id), which means this is an all-or-nothing. Since each call is bound to a single event, this single task never is called more than once for the same event_id and expect a sum of tags. This means we can simplify this by choosing not to handle that case at all and should get a, theoretically, substantial boost in performance.
mattrobenolt
force-pushed
the
eventtag-bulk-create
branch
from
e67eef4 to
c07f01c
Compare
This was referenced Mar 17, 2020
This was referenced Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easily possible that this is 10+ at bare minimum, sometimes into
hundreds of tags per Event.
So changing this to a bulk write means we have 1 transaction and one big
INSERT query which should be considerable speed improvement.
We can get away with this since we currently have a UNIQUE on (event_id,
key_id, value_id), which means this is an all-or-nothing. Since each
call is bound to a single event, this single task never is called more
than once for the same event_id and expect a sum of tags. This means we
can simplify this by choosing not to handle that case at all and should
get a, theoretically, substantial boost in performance.