feat(auth): Support migration of auth identity id value #6577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful when an auth provider needs to migrate a id from a legacy provider identifying id key to a new key.
Member
|
For context, this will let us migrate to Google's internal IDs, which we mistakenly didn't use when building SSO. |
Security concerns found
Generated by 🚫 danger |
Member
Author
|
And here's the associated Google Auth change: getsentry/sentry-auth-google#20 |
dcramer
approved these changes
Nov 16, 2017
Member
dcramer
left a comment
dcramer
left a comment
There was a problem hiding this comment.
would we be able to add a test for this behavior?
Member
Author
|
@dcramer yes added tests. |
Member
Author
|
@dcramer wanted to get your eyes on the tests real quick for a re-approve before merging. |
dcramer
approved these changes
Nov 21, 2017
evanpurkhiser
deleted the
featauth-support-migration-of-auth-identity-id-value
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports fixing our choice of identifier for google auth.