Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devenv): downgrade to colima 0.6.6 #67071

Merged
merged 3 commits into from
Mar 15, 2024
Merged

fix(devenv): downgrade to colima 0.6.6 #67071

merged 3 commits into from
Mar 15, 2024

Conversation

joshuarli
Copy link
Member

haven't done a full reset on my macos-14 M1 in a while so haven't noticed till now but 0.6.8 stalls during disk conversion

colima delete and remove ~/Library/Caches/lima, ~/.colima to get to a state where you can then repro with colima start

ref: abiosoft/colima#930

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 15, 2024
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixnship

@@ -177,6 +178,7 @@ def ensure_docker_cli_context(context: str):

config["currentContext"] = context

os.makedirs(config_dir, exist_ok=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smaller patch: os.makedirs(os.path.dirname(config_file), exist_ok=True)

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (933ee19) to head (a9cf646).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #67071      +/-   ##
==========================================
- Coverage   84.27%   83.12%   -1.15%     
==========================================
  Files        5307     5307              
  Lines      237299   237292       -7     
  Branches    41053    41053              
==========================================
- Hits       199972   197257    -2715     
- Misses      37109    39817    +2708     
  Partials      218      218              

see 233 files with indirect coverage changes

@joshuarli joshuarli merged commit 6b61d99 into master Mar 15, 2024
51 checks passed
@joshuarli joshuarli deleted the colima-0.6.6 branch March 15, 2024 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants