feat(ui): Change to use PluginsStore #6848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tchPlugins actions
Changes the following views: * Issue tracking * Plugin Details * Release Tracking
billyvg
force-pushed
the
fix/ui/issue-tracking-use-store
branch
from
158e0bc to
a0119c0
Compare
Generated by 🚫 danger |
MaxBittker
approved these changes
Jan 5, 2018
Contributor
MaxBittker
left a comment
MaxBittker
left a comment
There was a problem hiding this comment.
the split state thing is confusing, but the tests look good to help make up for that. 👍 Sorry for the slow review! this seems nice, I liked seeing your use of HOCs.
|
|
||
| export const PluginShape = PropTypes.shape(Plugin); | ||
|
|
||
| export const PluginsStore = PropTypes.shape({ |
| let organization = this.props.organization || this.getOrganization(); | ||
| let project = this.props.project || this.getProject(); | ||
|
|
||
| if (!project || !organization) return; |
Contributor
There was a problem hiding this comment.
when would this mount without having these?
Member
Author
There was a problem hiding this comment.
hmm it shouldn't, would it be better to throw an error here?
| * 2) We fetch "plugin details" via API and save it to local state as `pluginDetails`. | ||
| * This is because "details" call contains form `config` and the "list" endpoint does not. | ||
| * The more correct way would be to pass `config` to PluginConfig and use plugin from | ||
| * PluginsStore |
|
|
||
| toggleEnable(shouldEnable) { | ||
| let method = shouldEnable ? 'POST' : 'DELETE'; | ||
| // Enabled state is handled via PluginsStore and not via plugins detail |
Contributor
There was a problem hiding this comment.
this comment is slightly confusing, because the code seems like it sometimes defers to pluginDetails for enabled state
Member
Author
There was a problem hiding this comment.
It falls back to pluginDetails if for some reason it couldn't fetch the plugin from PluginsStore
| * | ||
| * This is made because some components (e.g. ProjectPluginDetail) takes project as prop | ||
| */ | ||
| class SettingsProjectProvider extends React.Component { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the following views:
Will make sep PR to clean up other project settings views that fetch plugins list