-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ref(projects): Remove team data from deleted project audit #6856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Migration Checklist
Generated by 🚫 danger |
mattrobenolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause a problem since the columns will be removed while the code still is running referencing it. This needs to remove the columns from code first, then ship the migration to drop the columns after that's out.
|
@mattrobenolt i did that as part of #6807 (a3e5145) which I was planning on merging first for that reason. buuut maybe it just makes more sense for me to pull that out into it's own PR since it doesn't have to be part of that. would that be better? |
|
Oh, I see, then you're going to have a conflict here anyways. So we're good after #6807 merges. Your call if you want to split it out more or not, I don't personally think it's that important. |
9c11a8d to
0836de4
Compare
|
ok @mattrobenolt this should be good to go now |
mattrobenolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You again need to recreate migration. :(
0836de4 to
0050447
Compare
depends on #6807
since projects will soon be able to be associated with multiple teams, i'm removing this data