Skip to content

Conversation

@macqueen
Copy link
Contributor

@macqueen macqueen commented Jan 3, 2018

depends on #6807

since projects will soon be able to be associated with multiple teams, i'm removing this data

@ghost
Copy link

ghost commented Jan 3, 2018

2 Warnings
⚠️ You should update CHANGES due to the size of this PR
⚠️ PR includes migrations

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a problem since the columns will be removed while the code still is running referencing it. This needs to remove the columns from code first, then ship the migration to drop the columns after that's out.

@macqueen
Copy link
Contributor Author

macqueen commented Jan 3, 2018

@mattrobenolt i did that as part of #6807 (a3e5145) which I was planning on merging first for that reason. buuut maybe it just makes more sense for me to pull that out into it's own PR since it doesn't have to be part of that. would that be better?

@mattrobenolt
Copy link
Contributor

Oh, I see, then you're going to have a conflict here anyways. So we're good after #6807 merges. Your call if you want to split it out more or not, I don't personally think it's that important.

@macqueen macqueen force-pushed the deleted-project-team branch from 9c11a8d to 0836de4 Compare January 11, 2018 22:32
@macqueen
Copy link
Contributor Author

ok @mattrobenolt this should be good to go now

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You again need to recreate migration. :(

#6961

@macqueen macqueen force-pushed the deleted-project-team branch from 0836de4 to 0050447 Compare January 12, 2018 22:06
@macqueen macqueen merged commit 762fee8 into master Jan 16, 2018
@macqueen macqueen deleted the deleted-project-team branch January 16, 2018 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants