feat(ui): Tweak form field layout #6879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
billyvg
commented
Jan 5, 2018
| width: 50%; | ||
| padding-left: 10px; | ||
| position: relative; | ||
| overflow: hidden; |
Member
Author
There was a problem hiding this comment.
Prevent controls with a long string from overflowing
|
|
||
| const FormFieldWrapper = styled(({highlighted, ...props}) => <Flex {...props} />)` | ||
| padding: 15px 20px; | ||
| padding: 15px 0 15px 20px; |
Member
Author
There was a problem hiding this comment.
Removed right padding because of whitespace from control state icons
| const FormFieldIsSaved = styled.div` | ||
| color: ${p => p.theme.green}; | ||
| animation: ${fadeOut} 0.3s ease 2s 1 forwards; | ||
| position: absolute; |
Member
Author
There was a problem hiding this comment.
Kind of hacky, but would have weird behavior if "saved" happens followed by "error" where both will be rendered
(current prod)
ckj
approved these changes
Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to change FormField layout a bit, only noticeable change is the padding-right which we can tweak a bit.
Reason for this is in a future PR where we have a field that overflows (API keys) and had to do various nesting of flex/non-flex boxes to support it (the error with
position: absolutemake things trickier)