Skip to content

feat(ui): Add "readonly" text input with copy button #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
billyvg merged 2 commits into from
Jan 5, 2018
Merged

feat(ui): Add "readonly" text input with copy button #6880

billyvg merged 2 commits into from
Jan 5, 2018

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Jan 5, 2018

  • Not 100% finished but usable
  • Will need some future work to style component

@billyvg billyvg requested a review from a team January 5, 2018 01:50
@ghost
Copy link

ghost commented Jan 5, 2018 •
edited by ghost
Loading

1 Warning
⚠️ You should update CHANGES due to the size of this PR

Generated by 🚫 danger

@billyvg billyvg mentioned this pull request Jan 5, 2018
Merged
MaxBittker
MaxBittker approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@MaxBittker MaxBittker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 would this be used for the sharelink and dsns?

@billyvg
Copy link
Member Author

billyvg commented Jan 5, 2018

DSNs + APIs

@billyvg billyvg merged commit cbdccac into master Jan 5, 2018
@billyvg billyvg deleted the feat/ui/text-copy-input branch January 5, 2018 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ckj ckj ckj approved these changes

+1 more reviewer

@MaxBittker MaxBittker MaxBittker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billyvg @ckj @MaxBittker