Skip to content

ref(ui): Refactor <Row> from organization members view #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
Jan 5, 2018
Merged

ref(ui): Refactor <Row> from organization members view #6885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/sentry/static/sentry/app/views/settings/components/row.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import {Flex} from 'grid-emotion';
import styled from 'react-emotion';

const Row = styled(Flex)`
border-bottom: 1px solid ${p => p.theme.borderLight};

&:last-child {
border: 0;
}
`;

export default Row;
13 changes: 3 additions & 10 deletions src/sentry/static/sentry/app/views/settings/organization/members/organizationMemberRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Flex, Box} from 'grid-emotion';
import {Box} from 'grid-emotion';
import PropTypes from 'prop-types';
import React from 'react';
import styled from 'react-emotion';
Expand All @@ -8,9 +8,10 @@ import Avatar from '../../../../components/avatar';
import Button from '../../../../components/buttons/button';
import Confirm from '../../../../components/confirm';
import Link from '../../../../components/link';
import Tooltip from '../../../../components/tooltip';
import LoadingIndicator from '../../../../components/loadingIndicator';
import Row from '../../components/row';
import SentryTypes from '../../../../proptypes';
import Tooltip from '../../../../components/tooltip';
import recreateRoute from '../../../../utils/recreateRoute';

const UserName = styled(Link)`
Expand All @@ -22,14 +23,6 @@ const Email = styled.div`
font-size: 14px;
`;

const Row = styled(Flex)`
border-bottom: 1px solid ${p => p.theme.borderLight};

&:last-child {
border: 0;
}
`;

export default class OrganizationMemberRow extends React.PureComponent {
static propTypes = {
routes: PropTypes.array,
Expand Down