Don't hard-cap EventMapping retention at 7d. #6887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
suggested changes
Jan 5, 2018
| model=models.EventMapping, | ||
| dtfield='date_added', | ||
| days=min(days, 7), | ||
| days=days, |
Contributor
There was a problem hiding this comment.
We should just roll this into BULK_QUERY_DELETES now and remove this special block entirely.
mattrobenolt
suggested changes
Jan 8, 2018
| # Deletions that use `BulkDeleteQuery` (and don't need to worry about child relations) | ||
| # (model, datetime_field, order_by) | ||
| BULK_QUERY_DELETES = [ | ||
| (models.EventMapping, 'date_added', None), |
Contributor
There was a problem hiding this comment.
Add -date_added instead of None. That's the order_by argument which we need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EventMapping is now only written to when an Event is sampled, the volume of this table has dropped dramatically.