fix(wizard): Skip deleted projects #6891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
Can we figure out if the UI currently shows them correctly? If not i would remove it from the actual endpoint that enumerates them. Otherwise skip like here. |
mitsuhiko
suggested changes
Jan 5, 2018
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
i'm okay with this but i want to know if this is not actually a bug in the enumeration endpoint instead
mitsuhiko
approved these changes
Jan 5, 2018
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
verified ui just skips deleted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where we try to query the DSN of deleted projects
Fixes SENTRY-58Z