fix(minidump): Linux support #6922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
jan-auer
commented
Jan 9, 2018
| return True | ||
|
|
||
| # For now, consider all linux objects in_app | ||
| # TODO(ja): Fix in_app using file paths |
Member
Author
There was a problem hiding this comment.
I want to fix this soon in a follow-up PR
mitsuhiko
approved these changes
Jan 9, 2018
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
I thought I already approved that. Anyways approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues to support Linux crash reports:
text/plain.is_image_from_app_bundle. In fact, it should check for well-known symbol locations (e.g. /usr/local/lib)merge_minidump_eventnow reverses the stacktrace order. The UI reverses stacktraces again and minidumps already contain them in the correct order.0.0.0as version number and addsuname -srvmoas build. Symbolic2.0.3has been updated to parse this already.