Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove logging the slack request body #70508

Merged
merged 1 commit into from
May 8, 2024

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested a review from a team May 8, 2024 15:37
@asottile-sentry asottile-sentry requested a review from a team as a code owner May 8, 2024 15:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 8, 2024
@asottile-sentry asottile-sentry enabled auto-merge (squash) May 8, 2024 15:37
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (eb4de59) to head (b34812a).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70508      +/-   ##
==========================================
- Coverage   80.00%   80.00%   -0.01%     
==========================================
  Files        6492     6492              
  Lines      289975   289999      +24     
  Branches    49956    49966      +10     
==========================================
+ Hits       232004   232018      +14     
- Misses      57560    57570      +10     
  Partials      411      411              
Files Coverage Δ
src/sentry/integrations/slack/requests/base.py 94.67% <ø> (-0.04%) ⬇️

... and 12 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit a736720 into master May 8, 2024
49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-dont-log-tokens-plz branch May 8, 2024 17:48
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants