feat(environments): Add environment list to project settings #7138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
lynnagara
force-pushed
the
env-project-settings
branch
3 times, most recently
from
3303b58 to
8e16625
Compare
billyvg
approved these changes
Feb 1, 2018
Member
There was a problem hiding this comment.
Let's use <PanelItem> - I'll have a PR to remove Row (they are dupes)
Member
There was a problem hiding this comment.
Do we use EnvironmentStore elsewhere? If so, a HoC would be nice, especially with planned redux change.
Member
Author
There was a problem hiding this comment.
👍 Will open a separate PR for this
lynnagara
force-pushed
the
env-project-settings
branch
from
8e16625 to
6ad4512
Compare
lynnagara
force-pushed
the
env-project-settings
branch
from
6ad4512 to
4524672
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.