Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class AccountAuthorizations extends AsyncView {
}

getTitle() {
return 'Approved Applications - Sentry';
return 'Approved Applications';
}

onRevoke(authorization) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ const ApiApplicationDetails = createReactClass({
onRemoveApplication(app) {},

getTitle() {
return 'Application Details - Sentry';
return 'Application Details';
},

render() {
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/apiApplications.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const ApiApplications = createReactClass({
},

getTitle() {
return 'API Applications - Sentry';
return 'API Applications';
},

render() {
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/views/apiTokens.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const ApiTokens = createReactClass({
},

getTitle() {
return 'API Tokens - Sentry';
return 'API Tokens';
},

render() {
Expand Down
7 changes: 5 additions & 2 deletions src/sentry/static/sentry/app/views/asyncView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ class AsyncView extends AsyncComponent {
}

getTitle() {
return 'Sentry';
return '';
}
render() {
let title = this.getTitle();
return (
<DocumentTitle title={this.getTitle()}>{this.renderComponent()}</DocumentTitle>
<DocumentTitle title={`${title ? `${title} - ` : ''}Sentry`}>
{this.renderComponent()}
</DocumentTitle>
);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class AccountAuthorizations extends AsyncView {
}

getTitle() {
return 'Approved Applications - Sentry';
return 'Approved Applications';
}

handleRevoke = authorization => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ class AccountEmails extends AsyncView {
return [['emails', ENDPOINT]];
}

getTitle() {
return 'Emails';
}

handleSubmitSuccess = (change, model, id) => {
model.setValue(id, '');
this.remountComponent();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ class AccountIdentities extends AsyncView {
return [['identities', ENDPOINT]];
}

getTitle() {
return 'Identities';
}

getDefaultState() {
return {
identities: [],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export default class AccountNotifications extends AsyncView {
return [['data', '/users/me/notifications/']];
}

getTitle() {
return 'Notifications';
}

renderBody() {
return (
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ class AccountSubscriptions extends AsyncView {
return [['subscriptions', ENDPOINT]];
}

getTitle() {
return 'Subscriptions';
}

handleToggle = (subscription, index, e) => {
let subscribed = !subscription.subscribed;
let oldSubscriptions = this.state.subscriptions;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ApiApplicationDetails extends AsyncView {
}

getTitle() {
return 'Application Details - Sentry';
return 'Application Details';
}

handleSubmitSuccess = (change, model, id) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class ApiApplications extends AsyncView {
}

getTitle() {
return 'API Applications - Sentry';
return 'API Applications';
}

handleCreateApplication = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class ApiNewToken extends React.Component {

render() {
return (
<DocumentTitle title="Create API Token">
<DocumentTitle title="Create API Token - Sentry">
<div>
<SettingsPageHeader title={t('Create New Token')} />
<TextBlock>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import TextBlock from '../components/text/textBlock';

class ApiTokens extends AsyncView {
getTitle() {
return 'API Tokens - Sentry';
return 'API Tokens';
}

getDefaultState() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`AccountEmails renders with emails 1`] = `
<SideEffect(DocumentTitle)
title="Sentry"
title="Emails - Sentry"
>
<div>
<SettingsPageHeading
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`AccountIdentities renders empty 1`] = `
<SideEffect(DocumentTitle)
title="Sentry"
title="Identities - Sentry"
>
<div>
<SettingsPageHeading
Expand Down Expand Up @@ -34,7 +34,7 @@ exports[`AccountIdentities renders empty 1`] = `

exports[`AccountIdentities renders list 1`] = `
<SideEffect(DocumentTitle)
title="Sentry"
title="Identities - Sentry"
>
<div>
<SettingsPageHeading
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`AccountSubscriptions renders empty 1`] = `
<SideEffect(DocumentTitle)
title="Sentry"
title="Subscriptions - Sentry"
>
<div>
<SettingsPageHeading
Expand Down Expand Up @@ -193,10 +193,10 @@ exports[`AccountSubscriptions renders list and can toggle 1`] = `

<AccountSubscriptions>
<SideEffect(DocumentTitle)
title="Sentry"
title="Subscriptions - Sentry"
>
<DocumentTitle
title="Sentry"
title="Subscriptions - Sentry"
>
<div>
<SettingsPageHeading
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`ApiNewToken render() renders 1`] = `
<SideEffect(DocumentTitle)
title="Create API Token"
title="Create API Token - Sentry"
>
<NarryLayout>
<h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`OrganizationCreate render() renders correctly 1`] = `
<SideEffect(DocumentTitle)
title="Create Organization"
title="Create Organization - Sentry"
>
<NarryLayout>
<h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ exports[`OrganizationIntegrations render() with a provider renders 1`] = `
}
>
<SideEffect(DocumentTitle)
title="Integrations"
title="Integrations - Sentry"
>
<DocumentTitle
title="Integrations"
title="Integrations - Sentry"
>
<div
className="ref-organization-integrations"
Expand Down Expand Up @@ -135,10 +135,10 @@ exports[`OrganizationIntegrations render() with a provider renders with a reposi
}
>
<SideEffect(DocumentTitle)
title="Integrations"
title="Integrations - Sentry"
>
<DocumentTitle
title="Integrations"
title="Integrations - Sentry"
>
<div
className="ref-organization-integrations"
Expand Down Expand Up @@ -340,7 +340,7 @@ exports[`OrganizationIntegrations render() with a provider renders with a reposi

exports[`OrganizationIntegrations render() without any providers is loading when initially rendering 1`] = `
<SideEffect(DocumentTitle)
title="Integrations"
title="Integrations - Sentry"
>
<div
className="ref-organization-integrations"
Expand Down Expand Up @@ -398,10 +398,10 @@ exports[`OrganizationIntegrations render() without any providers renders 1`] = `
}
>
<SideEffect(DocumentTitle)
title="Integrations"
title="Integrations - Sentry"
>
<DocumentTitle
title="Integrations"
title="Integrations - Sentry"
>
<div
className="ref-organization-integrations"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`ProjectAlertSettings render() renders 1`] = `
<SideEffect(DocumentTitle)
title="Project Alert Settings"
title="Project Alert Settings - Sentry"
>
<div>
<SettingsPageHeading
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,10 @@ exports[`ProjectPluginDetails renders 1`] = `
}
>
<SideEffect(DocumentTitle)
title="Sentry"
title="Sentry - Sentry"
>
<DocumentTitle
title="Sentry"
title="Sentry - Sentry"
>
<div>
<SettingsPageHeading
Expand Down
2 changes: 1 addition & 1 deletion tests/js/spec/views/__snapshots__/teamCreate.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`TeamCreate render() renders correctly 1`] = `
<SideEffect(DocumentTitle)
title="Create Team"
title="Create Team - Sentry"
>
<NarryLayout>
<h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`TeamSettings render() renders 1`] = `
<SideEffect(DocumentTitle)
title="Team Settings"
title="Team Settings - Sentry"
>
<div
className="box"
Expand Down