ref(proguard): Unconditionally use Symbolicator and remove StacktraceProcessor #73905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Swatinem
approved these changes
Jul 8, 2024
Swatinem
approved these changes
Jul 8, 2024
Member
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
this reminds me of further cleanup opportunities:
- remove proguard support from
ophio. although this was never actually used, I planned to replacesymbolicusage with that. - remove the proguard bindings from
symboliceventually. I believe the only thing thats left by then is a few calls toArchive. It should be possible to migrate those toophioat some point, so that we can completely remove the symbolic python bindings.
Contributor
Author
|
Good thinking, I opened getsentry/symbolic#851 and getsentry/ophio#58. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73905 +/- ##
==========================================
+ Coverage 77.98% 78.07% +0.08%
==========================================
Files 6663 6663
Lines 298120 297884 -236
Branches 51301 51242 -59
==========================================
+ Hits 232493 232572 +79
- Misses 58941 59040 +99
+ Partials 6686 6272 -414
|
loewenheim
changed the title
loewenheim
added a commit
that referenced
this pull request
Jul 8, 2024
These options are unused as of #73905.
loewenheim
added a commit
that referenced
this pull request
Jul 9, 2024
These options are unused as of #73905.
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 11, 2024
…Processor (#73905) We're at a point where we can definitely switch to Symbolicator for proguard processing. This removes all code related to gradual rollout and A/B testing (except the options), as well as the previous StacktraceProcessors.
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 11, 2024
These options are unused as of #73905.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're at a point where we can definitely switch to Symbolicator for proguard processing. This removes all code related to gradual rollout and A/B testing (except the options).