Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dart): add dart raw stacktrace representation #74715

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

buenaflor
Copy link
Contributor

For raw stacktraces we don't have a Dart stacktrace representation and we currently fall back to using getPythonFrame.

Related issue: getsentry/sentry-dart#2040

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 23, 2024
@buenaflor buenaflor requested a review from malwilley July 23, 2024 11:50
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (ae533db) to head (37a1c11).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74715      +/-   ##
==========================================
- Coverage   78.11%   78.11%   -0.01%     
==========================================
  Files        6738     6738              
  Lines      300479   300495      +16     
  Branches    51673    51678       +5     
==========================================
+ Hits       234723   234735      +12     
- Misses      59437    59444       +7     
+ Partials     6319     6316       -3     
Files Coverage Δ
.../interfaces/crashContent/stackTrace/rawContent.tsx 55.55% <77.77%> (+2.82%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codecov bot commented Jul 24, 2024

Bundle Report

Changes will increase total bundle size by 1.04kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.18MB 1.04kB ⬆️

@buenaflor buenaflor merged commit 6de2850 into master Jul 24, 2024
43 checks passed
@buenaflor buenaflor deleted the feat/dart-raw-stacktraces branch July 24, 2024 08:05
Christinarlong pushed a commit that referenced this pull request Jul 26, 2024
For raw stacktraces we don't have a Dart stacktrace representation and
we currently fall back to using `getPythonFrame`.

Related issue: getsentry/sentry-dart#2040
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants