feat(insights): add geo region selector in web vitals landing #76062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
0Calories
reviewed
Aug 13, 2024
static/app/views/insights/common/views/spans/selectors/subregionSelector.tsx
Outdated
Show resolved
Hide resolved
0Calories
reviewed
Aug 13, 2024
static/app/views/insights/common/views/spans/selectors/subregionSelector.tsx
Outdated
Show resolved
Hide resolved
0Calories
reviewed
Aug 13, 2024
static/app/views/insights/common/views/spans/selectors/subregionSelector.tsx
Outdated
Show resolved
Hide resolved
0Calories
reviewed
Aug 13, 2024
static/app/views/insights/common/views/spans/selectors/subregionSelector.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ash <0Calories@users.noreply.github.com>
Co-authored-by: Ash <0Calories@users.noreply.github.com>
Bundle ReportChanges will increase total bundle size by 66.61kB ⬆️
|
|
@0Calories Made the changes, thanks for the suggestions! |
ameliahsu
pushed a commit
that referenced
this pull request
Aug 13, 2024
Work towards #75230 Adds geo region selector, for now marked as "experimental" and internal only because we need to allow data to come in so its not always working. <img width="938" alt="image" src="https://github.com/user-attachments/assets/e60c71fc-b005-435c-a605-465f5acda2b1"> This will go in many other modules and areas of our app, but for now just web vitals landing for testing purposes. --------- Co-authored-by: Ash <0Calories@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #75230
Adds geo region selector, for now marked as "experimental" and internal only because we need to allow data to come in so its not always working.
This will go in many other modules and areas of our app, but for now just web vitals landing for testing purposes.