ref(control_silo): Move UserEmail model to users module #76134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of moving control silo user related resources into the users module. Includes adding of types for functions. Apart of (#73856)
github-actions
bot
added
the
Scope: Backend
Christinarlong
commented
Aug 13, 2024
Comment on lines
+95
to
+98
| def hash_is_valid(self) -> bool: | ||
| return bool( | ||
| self.validation_hash and self.date_hash_added > timezone.now() - timedelta(hours=48) | ||
| ) |
There was a problem hiding this comment.
coerced into bool to get return type to be only bool instead of bool | str
markstory
approved these changes
Aug 14, 2024
Christinarlong
deleted the
christinarlong/consolidate-users-models-useremail
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of moving control silo user related resources into the users module. Includes adding any missing types for the model.
Apart of (#73856)