nit(scm): group functions by class they come from in main integration class #76240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Aug 14, 2024
| @@ -362,6 +353,18 @@ def extract_source_path_from_source_url(self, repo: Repository, url: str) -> str | |||
| return qs["path"][0].lstrip("/") | |||
| return "" | |||
|
|
|||
| # Azure DevOps only methods | |||
|
|
|||
| def _check_domain_name(self, default_identity: RpcIdentity) -> None: | |||
There was a problem hiding this comment.
this is only used inside this class so i added an underscore
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #76240 +/- ##
===========================================
+ Coverage 46.81% 88.40% +41.59%
===========================================
Files 1891 2968 +1077
Lines 122785 185089 +62304
Branches 22108 32982 +10874
===========================================
+ Hits 57487 163637 +106150
+ Misses 64212 15463 -48749
- Partials 1086 5989 +4903 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__Integrationclasses (e.g.GitHubIntegration) inherit from several classes (ABCs), and they each implement functions from those parent classes. This PR moves functions such that they are grouped together via the ABC they come from, e.g.IntegrationInstallationfunctions orRepositoryIntegrationfunctions.