fix(deletion) Use a specialized deletion strategy for GroupHistory #76608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few deletions stuck for projects because of failures in deleting grouphistory. When removing a project it is possible for groups to have history records that have `prev_history` references that aren't within the same 10000 record batch as their parent. This was not reproducible in tests because tests run within a transaction so all batches are removed in the same transaction. By deleting history records by group we can ensure that constraints aren't violated. Most groups have fewer than 10k history records so we shouldn't hit query timeouts. Fixes SENTRY-19BG
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Aug 27, 2024
armenzg
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few deletions stuck for projects because of failures in deleting grouphistory. When removing a project it is possible for groups to have history records that have
prev_historyreferences that aren't within the same 10000 record batch as their parent. This was not reproducible in tests because tests run within a transaction so all batches are removed in the same transaction.By deleting history records by group we can ensure that constraints aren't violated. Most groups have fewer than 10k history records so we shouldn't hit query timeouts.
Fixes SENTRY-19BG