Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prepare to split save_event_transaction queue into 3 #78868

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: prepare to split save_event_transaction queue into 3 #78868

merged 3 commits into from
Oct 9, 2024

Conversation

lynnagara
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2024
@lynnagara lynnagara requested a review from a team October 9, 2024 19:36
markstory
markstory reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The region/control parts of this look good to me.

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/conf/server.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #78868   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files        7125     7125           
  Lines      313605   313609    +4     
  Branches    51181    51182    +1     
=======================================
+ Hits       245434   245440    +6     
+ Misses      61736    61734    -2     
  Partials     6435     6435

fpacifici
fpacifici approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@fpacifici fpacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider applying this change in s4s (from the ops repo first to ensure all is fine and it does not cause a core meltdown)

@lynnagara
Copy link
Member Author

i'm going to merge since this gets sent out to s4s first either way even without going through ops repo

@lynnagara lynnagara merged commit abfe52e into master Oct 9, 2024
49 of 50 checks passed
@lynnagara lynnagara deleted the split-save-transaction-queue branch October 9, 2024 21:46
@lynnagara lynnagara added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Oct 10, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 6a16f09

getsentry-bot added a commit that referenced this pull request Oct 10, 2024
@getsentry-bot @lynnagara
Revert "feat: prepare to split save_event_transaction queue into 3 (#…
6a16f09 
…78868)"

This reverts commit abfe52e.

Co-authored-by: lynnagara <1779792+lynnagara@users.noreply.github.com>
lynnagara added a commit that referenced this pull request Oct 10, 2024
@lynnagara
Revert "Revert "feat: prepare to split save_event_transaction queue i…
c90c83a 
…nto 3 (#78868)""

Retry #78868, this time with separate config
for region and control silo
@lynnagara lynnagara mentioned this pull request Oct 10, 2024
Merged
lynnagara added a commit that referenced this pull request Oct 10, 2024
@lynnagara
feat: 2nd attempt to split save_event_transaction into 3 queues (#78889)
429ccf6 
Retry #78868, this time with
separate config for region and control silo
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory left review comments

@fpacifici fpacifici fpacifici approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lynnagara @getsentry-bot @markstory @fpacifici