Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove tools.hack_pip #79555

Merged
merged 1 commit into from
Oct 28, 2024
Merged

ref: remove tools.hack_pip #79555

merged 1 commit into from
Oct 28, 2024

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Oct 22, 2024

  • this has been "broken" since end of july (when pip 24.2 released)
  • it's unclear when the underlying problem was fixed (if it was?)
  • I suspect github might have improved their networking? or gcp?
  • we haven't seen ReadTimeout errors though so presumably something in pip changed to resolve this
  • we can always bring this back later with the correct retry decorator -- but it's simpler to just remove this!
working around https://github.com/pypa/pip/issues/12383#issuecomment-1808598097
writing: /home/runner/work/sentry/sentry/.venv/lib/python3.12/site-packages/sentry-pip-hack.pth
Error processing line 1 of /home/runner/work/sentry/sentry/.venv/lib/python3.12/site-packages/sentry-pip-hack.pth:

  Traceback (most recent call last):
    File "<frozen site>", line 206, in addpackage
    File "<string>", line 1, in <module>
    File "<string>", line 2, in <module>
  ModuleNotFoundError: No module named 'pip._vendor.tenacity'

Remainder of file ignored

getsentry first: https://github.com/getsentry/getsentry/pull/15456

@asottile-sentry asottile-sentry requested a review from a team October 22, 2024 20:04
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 22, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@asottile-sentry asottile-sentry marked this pull request as ready for review October 28, 2024 15:07
@asottile-sentry asottile-sentry requested a review from a team as a code owner October 28, 2024 15:07
@asottile-sentry asottile-sentry merged commit 6ddaa27 into master Oct 28, 2024
55 checks passed
@asottile-sentry asottile-sentry deleted the asottile-remove-hack-pip branch October 28, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants