feat(crons): Implement simple incident occurence consumer #80773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
ba25e24
to
4f02b73
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
4f02b73
to
cc1b540
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80773 +/- ##
===========================================
+ Coverage 52.39% 78.40% +26.01%
===========================================
Files 7181 7206 +25
Lines 318146 319470 +1324
Branches 43822 43994 +172
===========================================
+ Hits 166690 250492 +83802
+ Misses 149801 62589 -87212
- Partials 1655 6389 +4734 |
JoshFerge
reviewed
Nov 14, 2024
JoshFerge
reviewed
Nov 14, 2024
JoshFerge
reviewed
Nov 14, 2024
JoshFerge
approved these changes
Nov 14, 2024
evanpurkhiser
changed the title
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
cc1b540
to
c2847f1
Compare
|
Updated with a couple error state test cases |
Simply deserializes the IncidentOccurrence messages and dispatches the incident occurrence. Does not yet determine if the clock tick should cause the dispatch to be delayed.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
c2847f1
to
293092e
Compare
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply deserializes the IncidentOccurrence messages and dispatches the
incident occurrence.
Does not yet determine if the clock tick should cause the dispatch to be
delayed.
Part of GH-79328