Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to backpressure redis clusters #81102

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kneeyo1
Copy link
Contributor

@kneeyo1 kneeyo1 commented Nov 21, 2024

Backpressure does not reinitalize redis cluster or single node redis connections on timeouts.

Some sort of maintenance event / replication failover in our redis cluster meant that an old host/port combo configured in our backpressure was no longer pointing to our active cluster. Backpressure started receiving timeouts when trying to get metrics, marking cluster as unhealthy. This should force it to reinit on timeout.

relates to getsentry/sentry-redis-tools#18

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2024
@lynnagara
Copy link
Member

should this be a backpressure-specific thing?

shouldn't redis cluster code behave this way by default everywhere?

Copy link

codecov bot commented Nov 21, 2024

❌ 1487 Tests Failed:

Tests completed Failed Passed Skipped
23116 1487 21629 215
View the top 3 failed tests by shortest run time
tests.sentry.hybridcloud.services.test_control_organization_provisioning.TestControlOrganizationProvisioningSlugUpdates__InControlMode::test_conflicting_unregistered_organization_with_slug_exists
Stack Traces | 0.005s run time
No failure message available
tests.sentry.users.api.endpoints.test_user_authenticator_details.UserAuthenticatorDetailsTest::test_sms_get_phone
Stack Traces | 0.005s run time
No failure message available
tests.sentry.users.web.test_accounts.TestAccounts::test_post_success
Stack Traces | 0.005s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants