Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Update eap alerts to display warning banner when low confidence data is detected #81105

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Nov 21, 2024

Updates EAP Alerts and supporting timeseries utilities (eventsRequest, etc) to handle confidence if it is returned by Discover. This PR assumes that discover timeseries intervals will include a confidence attribute alongside the original count, ie:

[timestamp, [{count: ...., confidence: HIGH|LOW}]]

example:
[1731556800, [{count: 100, confidence: 'LOW'}]],
[1731560400, [{count: 200, confidence: 'HIGH'}]],

If any low confidence interval is detected in the timeseries response of an EAP Alert, we display a warning banner.
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/alerts/rules/metric/ruleForm.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81105      +/-   ##
==========================================
+ Coverage   70.60%   78.43%   +7.82%     
==========================================
  Files        7215     7215              
  Lines      319471   318968     -503     
  Branches    20776    43936   +23160     
==========================================
+ Hits       225578   250192   +24614     
+ Misses      92965    62411   -30554     
- Partials      928     6365    +5437     

Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 6.24kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.99MB 6.24kB (0.02%) ⬆️

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 21, 2024 16:58
@edwardgou-sentry edwardgou-sentry requested review from a team as code owners November 21, 2024 16:58
@edwardgou-sentry edwardgou-sentry requested a review from a team November 21, 2024 16:58
@edwardgou-sentry edwardgou-sentry merged commit a67afa0 into master Nov 22, 2024
44 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/eap-alerts-confidence branch November 22, 2024 21:48
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
…nfidence data is detected (#81105)

Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`,
etc) to handle confidence if it is returned by Discover. This PR assumes
that discover timeseries intervals will include a `confidence` attribute
alongside the original count
If any low confidence interval is detected in the timeseries response of
an EAP Alert, we display a warning banner.
evanh pushed a commit that referenced this pull request Nov 25, 2024
…nfidence data is detected (#81105)

Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`,
etc) to handle confidence if it is returned by Discover. This PR assumes
that discover timeseries intervals will include a `confidence` attribute
alongside the original count
If any low confidence interval is detected in the timeseries response of
an EAP Alert, we display a warning banner.
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
…nfidence data is detected (#81105)

Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`,
etc) to handle confidence if it is returned by Discover. This PR assumes
that discover timeseries intervals will include a `confidence` attribute
alongside the original count
If any low confidence interval is detected in the timeseries response of
an EAP Alert, we display a warning banner.
Copy link

sentry-io bot commented Dec 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoBe�[2m(�[22m�[32mexpected�[39m�[2m) // Object.is e... Object.?(isLowConfidenceTimeSeries.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants