-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): Update eap alerts to display warning banner when low confidence data is detected #81105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terval is detected, plus minor improvements
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81105 +/- ##
==========================================
+ Coverage 70.60% 78.43% +7.82%
==========================================
Files 7215 7215
Lines 319471 318968 -503
Branches 20776 43936 +23160
==========================================
+ Hits 225578 250192 +24614
+ Misses 92965 62411 -30554
- Partials 928 6365 +5437 |
Bundle ReportChanges will increase total bundle size by 6.24kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
…ap-alerts-confidence
shruthilayaj
approved these changes
Nov 22, 2024
static/app/views/alerts/rules/metric/utils/getConfidenceMarkAreas.tsx
Outdated
Show resolved
Hide resolved
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
…nfidence data is detected (#81105) Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`, etc) to handle confidence if it is returned by Discover. This PR assumes that discover timeseries intervals will include a `confidence` attribute alongside the original count If any low confidence interval is detected in the timeseries response of an EAP Alert, we display a warning banner.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
…nfidence data is detected (#81105) Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`, etc) to handle confidence if it is returned by Discover. This PR assumes that discover timeseries intervals will include a `confidence` attribute alongside the original count If any low confidence interval is detected in the timeseries response of an EAP Alert, we display a warning banner.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…nfidence data is detected (#81105) Updates EAP Alerts and supporting timeseries utilities (`eventsRequest`, etc) to handle confidence if it is returned by Discover. This PR assumes that discover timeseries intervals will include a `confidence` attribute alongside the original count If any low confidence interval is detected in the timeseries response of an EAP Alert, we display a warning banner.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EAP Alerts and supporting timeseries utilities (
eventsRequest
, etc) to handle confidence if it is returned by Discover. This PR assumes that discover timeseries intervals will include aconfidence
attribute alongside the original count, ie:If any low confidence interval is detected in the timeseries response of an EAP Alert, we display a warning banner.
![image](https://private-user-images.githubusercontent.com/83961295/388558584-20b0ddf5-e161-492a-af7d-2a7d4c1aba72.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MTc0NzYsIm5iZiI6MTczOTcxNzE3NiwicGF0aCI6Ii84Mzk2MTI5NS8zODg1NTg1ODQtMjBiMGRkZjUtZTE2MS00OTJhLWFmN2QtMmE3ZDRjMWFiYTcyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE0NDYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2Y2Y1OWUwOGYxYTMwNDhlMzZlYWVhZjlkODM4YzYzOTdlNDAwMmFiMGJlZjliYTQ2M2ViMWE0ZDViY2IxZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.284v4T7HkAvR1MWRk7Jih_zFanhwvOPUrrZsdvpwX0I)