Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Update EAP Alert builder to use EAPSpanSearchQueryBuilder and Span Tags Provider #81152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edwardgou-sentry
Copy link
Contributor

Updates EAP Alert builder query filter field to use the EAPSpanSearchQueryBuilder component, same as Explore.
Also uses the SpanTagsProvider and context.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 5.05kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.96MB 5.05kB (0.02%) ⬆️

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/views/alerts/rules/metric/ruleConditionsForm.tsx 33.33% 6 Missing ⚠️
static/app/views/alerts/rules/metric/ruleForm.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81152      +/-   ##
==========================================
- Coverage   78.46%   78.44%   -0.03%     
==========================================
  Files        7209     7223      +14     
  Lines      319450   319947     +497     
  Branches    43959    44062     +103     
==========================================
+ Hits       250670   250967     +297     
- Misses      62383    62581     +198     
- Partials     6397     6399       +2     

@edwardgou-sentry edwardgou-sentry force-pushed the egou/feat/update-eap-alert-builder-to-use-eap-query-builder branch from 2427112 to b406825 Compare November 21, 2024 20:47
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants