fix(issues): Animate dropdown chevrons, button sizes #81262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes chevrons not animating when opening - adjust size of target for event id dropdown
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Nov 25, 2024
Comment on lines
-125
to
-130
| <Tooltip | ||
| title={event.id} | ||
| delay={500} | ||
| overlayStyle={{maxWidth: 'max-content'}} | ||
| disabled={isOpen} | ||
| > |
There was a problem hiding this comment.
removing the tooltip for now as that was causing issues with the dropdown button when disabled
need to followup with a fix on dropdown buttons with tooltips. they shouldn't trigger the tooltip on action
roggenkemper
approved these changes
Nov 25, 2024
scttcper
commented
Nov 25, 2024
| <StyledTimeSince | ||
| tooltipBody={<EventCreatedTooltip event={event} />} | ||
| tooltipProps={{overlayStyle: {maxWidth: 300}}} |
There was a problem hiding this comment.
popper throws an error when setting max width via style instead of their prop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old size of button target
new size of button target
