Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Release authors type incorrect #81346

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

scttcper
Copy link
Member

Release authors can be sentry users or they can be {name: string; email: string} if no user can be matched.

Fixes react error when iterating over users with no unique id for the key

Release authors can be sentry users or they can be `{name: string; email: string}` if no user can be matched.

Fixes react error when iterating over users with no unique id for the key
@scttcper scttcper requested review from a team as code owners November 26, 2024 22:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 26, 2024
@scttcper scttcper requested a review from a team November 26, 2024 22:07
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/releases/list/releaseCard/releaseCardCommits.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81346      +/-   ##
==========================================
- Coverage   80.35%   80.35%   -0.01%     
==========================================
  Files        7219     7219              
  Lines      319567   319579      +12     
  Branches    20769    20769              
==========================================
+ Hits       256780   256785       +5     
- Misses      62393    62400       +7     
  Partials      394      394              

@scttcper scttcper merged commit 049024d into master Nov 26, 2024
45 checks passed
@scttcper scttcper deleted the scttcper/fix-release-author-type branch November 26, 2024 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants