fix: add os.distribution_X FieldKey values to autofill search #81656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JoshuaMoelans
commented
Dec 4, 2024
Comment on lines
+1922
to
+1923
| FieldKey.OS_DISTRIBUTION_NAME, | ||
| FieldKey.OS_DISTRIBUTION_VERSION, |
There was a problem hiding this comment.
Not sure if they conflict with tags, but put them in here as well since the OS_KERNEL_VERSION is here too.
narsaynorath
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good! They're showing up in issues search now. We have docs pages that list out the searchable fields, we should add this to both the one for issues and one for events near the other OS keys
https://docs.sentry.io/concepts/search/searchable-properties/events/#osbuild
https://docs.sentry.io/concepts/search/searchable-properties/issues/#osbuild
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the following sentry-native PR we want to be able to search on these recently added fields by having them autofill.
Originally added (unflattened) in #69865
Flattened them for searchability in #81297