Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): Fix EAP alert filter bar to behave more like explore #81946

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Dec 10, 2024

Updates the search bar in the EAP Alert edit page to behave more like explore:

  • User must explicitly save changes on the search (hitting enter) for updates to take effect. Same as explore.
  • Removed onBlur handler

This also fixes an issue where the chart visualization updates, but saving the alert rule doesn't actually save the changed filter because it was not actually committed

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 10, 2024
@edwardgou-sentry edwardgou-sentry requested a review from a team December 10, 2024 22:10
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review December 10, 2024 22:10
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner December 10, 2024 22:10
@edwardgou-sentry edwardgou-sentry merged commit 7e3b651 into master Dec 11, 2024
45 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/eap-alert-search-bar branch December 11, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants