Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autofix): Add support for streamed output #82024

Merged
merged 3 commits into from
Dec 13, 2024
Merged

feat(autofix): Add support for streamed output #82024

merged 3 commits into from
Dec 13, 2024

Conversation

roaga
Copy link
Member

@roaga roaga commented Dec 12, 2024

  1. Adds a placeholder card that renders streamed text output
  2. Updates animations to fit better
  3. Reduces polling interval to 500 ms.
Screenshot 2024-12-12 at 9 31 36 AM

@roaga roaga requested a review from jennmueng December 12, 2024 19:14
@roaga roaga requested a review from a team as a code owner December 12, 2024 19:14
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 12, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.95kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.11MB 2.95kB (0.01%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #82024      +/-   ##
==========================================
- Coverage   80.36%   80.36%   -0.01%     
==========================================
  Files        7274     7274              
  Lines      321267   321263       -4     
  Branches    20949    20949              
==========================================
- Hits       258173   258169       -4     
  Misses      62683    62683              
  Partials      411      411

jennmueng
jennmueng approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jennmueng jennmueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roaga roaga merged commit 0908e1f into master Dec 13, 2024
43 checks passed
@roaga roaga deleted the autofix/streaming branch December 13, 2024 22:56
evanh pushed a commit that referenced this pull request Dec 17, 2024
@roaga @evanh
feat(autofix): Add support for streamed output (#82024)
6126baf 
1. Adds a placeholder card that renders streamed text output
2. Updates animations to fit better
3. Reduces polling interval to 500 ms.

<img width="690" alt="Screenshot 2024-12-12 at 9 31 36 AM"
src="https://github.com/user-attachments/assets/286761b0-6f42-42c2-8090-ace2aa1a048e"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jennmueng jennmueng jennmueng approved these changes

@trillville trillville trillville approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roaga @trillville @jennmueng