feat(dashboards): enable sorting by column in table view #82239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good to me. I tested it out locally. The only thing I could find was a little weird was clicking on Owner allowed a sort, but there wasn't a direction arrow associated with the column. Because I know it's not an alphabetical sort this makes some sense but does Vasudha have any plans to handle this?
I had only favourited my own dashboards, so when I clicked "Owner" I didn't think anything happened at first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sorting by column in dashboards table view.
name,date created, andownerName (Z-A)to dropdown to maintain consistency b/w grid and table viewownercolumn makes your dashboards show up on top (i.e.myDashboardsin the sort dropdown)