support routing stale messages to lowpri topic #82322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sentry consumer configuration now supports an optional `stale_topic`. if passed, all invalid message rejected with reason "stale" get routed to the stale topic. raising stale message exceptions is configured for the transactions consumer when the arg is passed
github-actions
bot
added
the
Scope: Backend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
lynnagara
force-pushed
the
dlq-producer-2-topics
branch
from
13b57c4 to
4a2bb2d
Compare
kneeyo1
reviewed
Dec 18, 2024
lynnagara
commented
Dec 19, 2024
| ], | ||
| ) | ||
| @django_db_all | ||
| def test_dlq_stale_messages(factories, topic_name) -> None: |
There was a problem hiding this comment.
this test doesn't belong here since this is the ingest consumer mode. We are testing a strategy that is agnostic of any specific consumer. test file structure matches the module being tested so it should be under consumers/test_dlq
lynnagara
commented
Dec 19, 2024
kneeyo1
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sentry consumer configuration now supports an optional
stale_topic. if passed, all invalid message rejected with reason "stale" get routed to the stale topic.raising stale message exceptions is configured for the transactions consumer