chore(seer grouping): Remove older stacktrace length filtering code #82434
+16
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82434 +/- ##
=======================================
Coverage 80.42% 80.43%
=======================================
Files 7315 7315
Lines 322577 322555 -22
Branches 21039 21039
=======================================
- Hits 259447 259433 -14
+ Misses 62723 62715 -8
Partials 407 407 |
lobsterkatie
force-pushed
the
kmclb-remove-too-many-frames-exception-code
branch
from
54b7f0f to
839c94d
Compare
armenzg
approved these changes
Dec 20, 2024
Base automatically changed from
kmclb-use-tallies-for-excessive-frame-seer-filter
to
master
December 20, 2024 17:44
lobsterkatie
force-pushed
the
kmclb-remove-too-many-frames-exception-code
branch
from
839c94d to
05561aa
Compare
armenzg
approved these changes
Dec 20, 2024
lobsterkatie
force-pushed
the
kmclb-remove-too-many-frames-exception-code
branch
from
05561aa to
9bef88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I won't merge this until we're happy with the results of #82414.
This is a follow-up to #82414, which added a stacktrace length filter on Seer calls based on the frame counts added recently to
StacktraceGroupingComonent. Now that that code is handling the filtering, the current implementation, which is somewhat more complex and is based on throwing and catchingTooManyOnlySystemFramesException, can be removed.