Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eap): Numeric attribute filtering in snql eap #82472

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(eap): Numeric attribute filtering in snql eap #82472

merged 1 commit into from
Dec 20, 2024
+37 −2

Conversation

Zylphrex
Copy link
Member

RPC isn't fully stable yet so fix this in SnQL first.

@Zylphrex
fix(eap): Numeric attribute filtering in snql eap
444e244 
RPC isn't fully stable yet so fix this in SnQL first.
@Zylphrex Zylphrex requested a review from a team as a code owner December 20, 2024 17:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2024
@Zylphrex Zylphrex merged commit 0f44d1b into master Dec 20, 2024
50 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/numeric-attribute-filtering-in-snql-eap branch December 20, 2024 19:36
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 20, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: assert [{'id': '6c0c...number]': 30}] == [{'id': '006c...number]': 30}] pytest.runtest.protocol tests/snuba/api/endpoin... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmak wmak wmak approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zylphrex @wmak