Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-details): Allow filters for first/last/recommended #82476

Merged
merged 13 commits into from
Jan 2, 2025

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Dec 20, 2024

This PR does a few things, but mostly addresses the inconsistencies with filtering in the streamlined UI.

  • Filters will now apply to the queries for First/Last/Recommended to ensure better results for the loaded event, matching the user expectations. These filters are env, date range, and queries.
  • The missing event state has been redesigned to be more helpful, letting users easily click to recommended/clear filters and adds a graphic.
  • The first/last/recommended buttons will now be accessible even when an event is not loaded

Specific event missing

image

Query doesn't find anything

image

todo

  • Add or update tests

@leeandher leeandher requested review from a team as code owners December 20, 2024 17:48
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Bundle Report

Changes will decrease total bundle size by 78.49kB (-0.24%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.04MB 78.49kB (-0.24%) ⬇️

Copy link
Member

@roggenkemper roggenkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the preloading for prev/next events is broken with these changes on my end - mind double checking if they work for you?

@roggenkemper
Copy link
Member

i'm personally not the biggest fan of including this line - "404: Event not found. The event ID may be incorrect, or it's age exceeded the retention period." to me , it feels weird that we are explicitly saying it's a 404 and the rest of it feels like it could be bullet points in the section below

t(
'Change up your filters. Try more environments, a wider date range, or a different query'
),
tct('If nothing stands out, try [link:clearing your filters] all together', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great

@leeandher
Copy link
Member Author

i'm personally not the biggest fan of including this line - "404: Event not found. The event ID may be incorrect, or it's age exceeded the retention period." to me , it feels weird that we are explicitly saying it's a 404 and the rest of it feels like it could be bullet points in the section below

That's fair, that error message comes directly from the endpoint. Should we just omit displaying the 404 in the UI all together? The endpoint will keep the error messages for users using the API directly.

@leeandher
Copy link
Member Author

Removed the error from being displayed and also made some context changes so that the new event count would show up in the dropdown.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #82476   +/-   ##
=======================================
  Coverage   72.48%   72.49%           
=======================================
  Files        7306     7306           
  Lines      322126   322090   -36     
  Branches    21011    21000   -11     
=======================================
- Hits       233488   233486    -2     
+ Misses      87445    87411   -34     
  Partials     1193     1193           

@leeandher
Copy link
Member Author

Updated Designs:
image

@leeandher leeandher requested a review from a team January 2, 2025 19:29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run this through https://svgomg.net/

Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way less confusing 👍

@leeandher leeandher merged commit 7aa0eb7 into master Jan 2, 2025
42 checks passed
@leeandher leeandher deleted the leander/return-no-event-frontend branch January 2, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants