Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry apps): Audit Sentry App Errors #82503

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

not going to get merged, I just need to see (and copy paste) the changes to new PRs :oopsie

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2024
src/sentry/sentry_apps/utils/errors.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Dec 20, 2024

❌ 49 Tests Failed:

Tests completed Failed Passed Skipped
23381 49 23332 214
View the top 3 failed tests by shortest run time
tests.sentry.sentry_apps.api.endpoints.test_sentry_apps.PostSentryAppsTest::test_missing_webhook_url
Stack Traces | 1.47s run time
#x1B[1m#x1B[.../api/endpoints/test_sentry_apps.py#x1B[0m:694: in test_missing_webhook_url
    assert "webhookUrl" in response.data
#x1B[1m#x1B[31mE   assert 'webhookUrl' in {'error': "{'webhookUrl': 'webhookUrl required for public integrations'}"}#x1B[0m
#x1B[1m#x1B[31mE    +  where {'error': "{'webhookUrl': 'webhookUrl required for public integrations'}"} = <Response status_code=400, "application/json">.data#x1B[0m
tests.sentry.sentry_apps.api.endpoints.test_sentry_apps.PostSentryAppsTest::test_cannot_create_app_without_correct_permissions
Stack Traces | 1.54s run time
#x1B[1m#x1B[.../api/endpoints/test_sentry_apps.py#x1B[0m:589: in test_cannot_create_app_without_correct_permissions
    assert response.data == {"events": ["issue webhooks require the event:read permission."]}
#x1B[1m#x1B[31mE   assert {'error': "{'...ermission.'}"} == {'events': ['...permission.']}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Left contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'error': "{'events': 'issue webhooks require the event:read permission.'}"}#x1B[0m
#x1B[1m#x1B[31mE     Right contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'events': ['issue webhooks require the event:read permission.']}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       {#x1B[0m
#x1B[1m#x1B[31mE     -     'events': [#x1B[0m
#x1B[1m#x1B[31mE     -         'issue webhooks require the event:read permission.',#x1B[0m
#x1B[1m#x1B[31mE     ?     ^^^#x1B[0m
#x1B[1m#x1B[31mE     +     'error': "{'events': 'issue webhooks require the event:read permission.'}",#x1B[0m
#x1B[1m#x1B[31mE     ?     ^^^^^^^^^^^^^^^^^^^^                                                    ++#x1B[0m
#x1B[1m#x1B[31mE     -     ],#x1B[0m
#x1B[1m#x1B[31mE       }#x1B[0m
tests.sentry.sentry_apps.api.endpoints.test_sentry_apps.PostSentryAppsTest::test_no_author_public_integration
Stack Traces | 1.54s run time
#x1B[1m#x1B[.../api/endpoints/test_sentry_apps.py#x1B[0m:717: in test_no_author_public_integration
    assert response.data == {"author": ["author required for public integrations"]}
#x1B[1m#x1B[31mE   assert {'error': "{'...tegrations'}"} == {'author': ['...ntegrations']}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Left contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'error': "{'author': 'author required for public integrations'}"}#x1B[0m
#x1B[1m#x1B[31mE     Right contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'author': ['author required for public integrations']}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       {#x1B[0m
#x1B[1m#x1B[31mE     -     'author': [#x1B[0m
#x1B[1m#x1B[31mE     -         'author required for public integrations',#x1B[0m
#x1B[1m#x1B[31mE     ?     ^^^^#x1B[0m
#x1B[1m#x1B[31mE     +     'error': "{'author': 'author required for public integrations'}",#x1B[0m
#x1B[1m#x1B[31mE     ?     ^^^^^^^^^^^       ++++++++++                                  ++#x1B[0m
#x1B[1m#x1B[31mE     -     ],#x1B[0m
#x1B[1m#x1B[31mE       }#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant