ref(replay): Refactor video-replay related css #82514
Open
+12
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves two bits of mobile-replay video-replay CSS closer to where it's needed.
first, i moved the
.video-replayerclass down from videoReplayerWithInteractions.tsx and into videoReplayer.tsx with the new name.video-replayer-wrapper.Then i updated the selectors to use sibling selections. So if the video wrapper exists it'll kick in.
We want the
opacityrule to kick in no matter the use-case, so that stays inside styles.tsx. But the absolute positioning is only for the olderstatic/app/components/replays/replayPlayer.tsxand not the newerstatic/app/components/replays/player/replayPlayer.tsx.The newer one, when it gets support for video replays, will use
<Stacked>instead ofpostition:absolute;like this.