ref(replay): Make root in VideoReplay* classes non-nullable #82517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82517 +/- ##
===========================================
- Coverage 86.70% 80.43% -6.27%
===========================================
Files 9414 7316 -2098
Lines 538327 322632 -215695
Branches 21047 21046 -1
===========================================
- Hits 466745 259504 -207241
+ Misses 71175 62721 -8454
Partials 407 407 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
The class is only instantiated from one spot, and there's a guard to make sure root is not-null: https://github.com/getsentry/sentry/blob/2c797560316c1666a0aca53b6eaa9f90bd3cd6e0/static/app/components/replays/replayContext.tsx#L394-L396 Lets lean into that and enforce it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class is only instantiated from one spot, and there's a guard to make sure root is not-null:
sentry/static/app/components/replays/replayContext.tsx
Lines 394 to 396 in 2c79756
Lets lean into that and enforce it.